[ovs-git] [ovn-org/ovn] 7fd0e5: northd: Treat reachable and unreachable VIPs diffe...

[numansiddique]

  Branch: refs/heads/branch-21.09
  Home:   https://github.com/ovn-org/ovn
  Commit: 7fd0e56df6f92ba1f4e80c54fdb3b6b5554ad480
      https://github.com/ovn-org/ovn/commit/7fd0e56df6f92ba1f4e80c54fdb3b6b5554ad480
  Author: Numan Siddique <numans at ovn.org>
  Date:   2021-11-09 (Tue, 09 Nov 2021)

  Changed paths:
    M northd/northd.c
    M northd/ovn-northd.8.xml
    M tests/ovn-northd.at
    M tests/ovn.at

  Log Message:
  -----------
  northd: Treat reachable and unreachable VIPs differently.

If a logical switch is used to join multiple gateway
routers and if each of these gateway routers are
configured with the same load balancer,  then after the
commit [1] it's results in a flow explosion in
the "ls_in_l2_lkup" stage of this logical switch.

So, this patch reverts parts of the commit [1] related to
the load balancer VIPs.

Eg. If a load balancer with vip - 5.0.0.48 is configured
on gateway routers g0, g1 and g2.  Then ovn-northd will add
the below logical flows

table=22(ls_in_l2_lkup), priority=80,
  match=(flags[1] == 0 && arp.op == 1 && arp.tpa == 5.0.0.48),
  action=(outport = "join-to-g0-port"; output;)
table=22(ls_in_l2_lkup), priority=80,
  match=(flags[1] == 0 && arp.op == 1 && arp.tpa == 5.0.0.48),
  action=(outport = "join-to-g1-port"; output;)
table=22(ls_in_l2_lkup), priority=80,
  match=(flags[1] == 0 && arp.op == 1 && arp.tpa == 5.0.0.48),
  action=(outport = "join-to-g2-port"; output;)

After this patch,  we will just have one lflow
table=22(ls_in_l2_lkup), priority=90,
  match=(flags[1] == 0 && arp.op == 1 && arp.tpa == 5.0.0.48),
  action=(outport = "_MC_flood"; output;)

[1] - ccbbbd0584e5("ovn-northd: Treat reachable and unreachable addresses identically.")
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2020710
Fixes: ccbbbd0584e5("ovn-northd: Treat reachable and unreachable addresses identically.")
Signed-off-by: Numan Siddique <numans at ovn.org>
Acked-by: Dumitru Ceara <dceara at redhat.com>
(cherry picked from commit bb715113f9cb5a551753f04e48e3f0dd3839124f)


  Commit: 20688808f467d888bee234632fe2eda15eeaa1e2
      https://github.com/ovn-org/ovn/commit/20688808f467d888bee234632fe2eda15eeaa1e2
  Author: Numan Siddique <numans at ovn.org>
  Date:   2021-11-09 (Tue, 09 Nov 2021)

  Changed paths:
    M northd/northd.c
    M northd/ovn-northd.8.xml
    M tests/ovn-northd.at

  Log Message:
  -----------
  northd: Don't add ARP responder flows for unreachable VIPs.

If a logical router is associated with load balancer VIPs which
are unreachable from it, we don't need to add ARP responder flows
in the L2_LKUP stage of ingress pipeline of the logical switches
connected to the router.  This patch removes these flows.

Signed-off-by: Numan Siddique <numans at ovn.org>
Acked-by: Dumitru Ceara <dceara at redhat.com>
(cherry picked from commit 45d9840eae7c656596dc95c8e0016f53327852f2)


Compare: https://github.com/ovn-org/ovn/compare/323f036db9c6...20688808f467