[ovs-git] [ovn-org/ovn] 0df684: inc-proc-northd: Don't reset I-P engine force reco...

Dumitru Ceara noreply at github.com
Mon Nov 29 21:38:58 UTC 2021


  Branch: refs/heads/main
  Home:   https://github.com/ovn-org/ovn
  Commit: 0df68408a6f220fd8f0eccf501c6ffe6a9ff323c
      https://github.com/ovn-org/ovn/commit/0df68408a6f220fd8f0eccf501c6ffe6a9ff323c
  Author: Dumitru Ceara <dceara at redhat.com>
  Date:   2021-11-29 (Mon, 29 Nov 2021)

  Changed paths:
    M northd/inc-proc-northd.c

  Log Message:
  -----------
  inc-proc-northd: Don't reset I-P engine force recompute.

In some cases, e.g., when ovn-northd reconnects to NB or SB, a full
recompute must be triggered.  In such cases inc_proc_northd_run() is
called with 'recompute=true' and it should in turn call
engine_set_force_recompute(true).

However, when 'recompute=false', inc_proc_northd_run() should not
reset the I-P engine forced recompute request.  The only time when
force-recompute should be set to 'false' is after a successful engine
run.

Fixes: 4597317f16d1 ("northd: Introduce incremental processing for northd")
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>


  Commit: 953832eb17f31374ba3cbc5db99d63b134fc626c
      https://github.com/ovn-org/ovn/commit/953832eb17f31374ba3cbc5db99d63b134fc626c
  Author: Dumitru Ceara <dceara at redhat.com>
  Date:   2021-11-29 (Mon, 29 Nov 2021)

  Changed paths:
    M northd/ovn-northd.c

  Log Message:
  -----------
  ovn-northd: Don't trigger recompute for transactions that are in progress.

Most of the times ovsdb_idl_loop_commit_and_wait() will return -1
indicating that the newly initiated transaction is still in progress.

That's not an error condition and it shouldn't trigger a forced
recompute.  Moreover, arguably, we shouldn't clear tracked rows only
when the transaction is successful.  We should probably do it
unconditionally in every iteration, to avoid processing the same update
twice.

Fixes: 4597317f16d1 ("northd: Introduce incremental processing for northd")
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>


  Commit: 9e8d24eb7736e58db889c6056e7f40843f973434
      https://github.com/ovn-org/ovn/commit/9e8d24eb7736e58db889c6056e7f40843f973434
  Author: Dumitru Ceara <dceara at redhat.com>
  Date:   2021-11-29 (Mon, 29 Nov 2021)

  Changed paths:
    M NEWS
    M controller/ovn-controller.c
    M lib/inc-proc-eng.c
    M lib/inc-proc-eng.h

  Log Message:
  -----------
  inc-proc-eng: Add inc-engine/recompute command.

This will be automatically available to all incremental processing
engine clients (ovn-northd and ovn-controller).

At the same time, deprecate the ovn-controller "recompute" command.

Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>


Compare: https://github.com/ovn-org/ovn/compare/b6a750112324...9e8d24eb7736


More information about the git mailing list