[ovs-git] [ovn-org/ovn] 465c18: ovn-controller: Avoid infinite replying for TCP/IC...

Mohammad Heib noreply at github.com
Tue Nov 30 16:29:12 UTC 2021


  Branch: refs/heads/branch-21.09
  Home:   https://github.com/ovn-org/ovn
  Commit: 465c18080a3bdd6737e7d0246803e428209b1446
      https://github.com/ovn-org/ovn/commit/465c18080a3bdd6737e7d0246803e428209b1446
  Author: Mohammad Heib <mheib at redhat.com>
  Date:   2021-11-30 (Tue, 30 Nov 2021)

  Changed paths:
    M controller/pinctrl.c
    M tests/ovn.at

  Log Message:
  -----------
  ovn-controller: Avoid infinite replying for TCP/ICMP connection reset messages

When the ovn controller receives an ip packet that targets a lport that has ACL
rule to reject ip packets, the controller will reply with TCP_RST or icmp4/6 unreachable packet
to notify the sender that the destination is not available.

In turn, the receiver host will receive the notification packet and handle it as a normal IP packet
and if the receiver host is part of the same logical-switch/port-group or has IP reject ACL rule
it will send TCP_RST or icmp4/6 unreachable packet replying to the TCP_RST or icmp4/6 unreachable
packet we received and here we will enter to an infinity loop of replying about replying which
will consume high CPU.

To avoid such scenarios this patch proposes to drop/ignore TCP_RST or icmp4/6 unreachable packets
that received on lport that has  IP reject ACL rules.

Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1934011
Fixes: 64f8c9e9f ("actions: Add a new OVN action - reject {}.")
Signed-off-by: Mohammad Heib <mheib at redhat.com>
Signed-off-by: Numan Siddique <numans at ovn.org>
(cherry picked from commit bcd9a8fb1b60accd6560c45e69ea80b70b2d3346)




More information about the git mailing list