[ovs-git] [ovn-org/ovn] 11fb40: test: Fix options:requested-chassis with hostname
Frode Nordahl
noreply at github.com
Tue Oct 5 02:32:29 UTC 2021
Branch: refs/heads/branch-21.09
Home: https://github.com/ovn-org/ovn
Commit: 11fb404e06c63f0bbc7e871302c1f577c8063a91
https://github.com/ovn-org/ovn/commit/11fb404e06c63f0bbc7e871302c1f577c8063a91
Author: Frode Nordahl <frode.nordahl at canonical.com>
Date: 2021-10-04 (Mon, 04 Oct 2021)
Changed paths:
M tests/ovn.at
Log Message:
-----------
test: Fix options:requested-chassis with hostname
This test currently passes, but is broken in two ways.
1) The `fetch_column` helper should be used to retrieve the value
of hostname, not `fetch` wich results in a "fetch: command not
found" error which is currently not caught by the test. As a
consequence the requested-chassis option was set to the empty
string ("") and not the chassis hostname.
2) When we introduced testing with TLS+RBAC in c948d6bb05b4 the
ovn_az_attach helper was updated to set the hostname to match
system-id. This of course also makes the name and hostname
columns in the Chassis record contain the same value which made
this test no longer do what it says on the tin.
Update test to explicitly set the value to be used for
requested-chassis option in the Chassis hostname record, and
add a check for it not being empty nor equal to chassis name.
Fixes: 4afe409e95c7 ("tests: Introduce new testing helpers.")
Fixes: c948d6bb05b4 ("tests: Test with SSL and RBAC for controller by default")
Signed-off-by: Frode Nordahl <frode.nordahl at canonical.com>
Signed-off-by: Numan Siddique <numans at ovn.org>
(cherry picked from commit 9dadbd482cc09b86a81e72887f8ce7849f70b2af)
More information about the git
mailing list