[ovs-git] [openvswitch/ovs] 34fbdc: python: idl: Avoid sending transactions when the D...

Ilya Maximets noreply at github.com
Tue Oct 12 19:11:02 UTC 2021


  Branch: refs/heads/master
  Home:   https://github.com/openvswitch/ovs
  Commit: 34fbdc41084c16f855efa9c56086b03644408b7d
      https://github.com/openvswitch/ovs/commit/34fbdc41084c16f855efa9c56086b03644408b7d
  Author: Terry Wilson <twilson at redhat.com>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M python/ovs/db/idl.py

  Log Message:
  -----------
  python: idl: Avoid sending transactions when the DB is not synced up.

This ports the C IDL change f50714b to the Python IDL:

Until now the code here would happily try to send transactions to the
database server even if the database connection was not in the correct
state.  In some cases this could lead to strange behavior, such as sending
a database transaction for a database that the IDL had just learned did not
exist on the server.

Signed-off-by: Terry Wilson <twilson at redhat.com>
Acked-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: cc0a87b11cea1fae8c8d4841486b3a3cff8303eb
      https://github.com/openvswitch/ovs/commit/cc0a87b11cea1fae8c8d4841486b3a3cff8303eb
  Author: Kumar Amber <kumar.amber at intel.com>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M tests/pmd.at

  Log Message:
  -----------
  pmd.at: Add test-cases for DPCLS and DPIF commands.

Added 2 separate test-cases for DPCLS and DPIF commands:
1018: PMD - dpcls configuration
1017: PMD - dpif configuration

The above added tests are to test the commands which are used
to either get or set the dpcls and dpif function pointers to
various different implementations like AVX512 or auto-validator
based on different CPU ISA supported.

Signed-off-by: Kumar Amber <kumar.amber at intel.com>
Acked-by: Kevin Traynor <ktraynor at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 4a6217fab1ae2e462fbe3db89e764418b6b55726
      https://github.com/openvswitch/ovs/commit/4a6217fab1ae2e462fbe3db89e764418b6b55726
  Author: Dumitru Ceara <dceara at redhat.com>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M datapath/conntrack.c

  Log Message:
  -----------
  datapath: handle DNAT tuple collision.

Upstream commit:
    commit 8aa7b526dc0b5dbf40c1b834d76a667ad672a410
    Author: Dumitru Ceara <dceara at redhat.com>
    Date:   Wed Oct 7 17:48:03 2020 +0200

    openvswitch: handle DNAT tuple collision

    With multiple DNAT rules it's possible that after destination
    translation the resulting tuples collide.

    For example, two openvswitch flows:
    nw_dst=10.0.0.10,tp_dst=10, actions=ct(commit,table=2,nat(dst=20.0.0.1:20))
    nw_dst=10.0.0.20,tp_dst=10, actions=ct(commit,table=2,nat(dst=20.0.0.1:20))

    Assuming two TCP clients initiating the following connections:
    10.0.0.10:5000->10.0.0.10:10
    10.0.0.10:5000->10.0.0.20:10

    Both tuples would translate to 10.0.0.10:5000->20.0.0.1:20 causing
    nf_conntrack_confirm() to fail because of tuple collision.

    Netfilter handles this case by allocating a null binding for SNAT at
    egress by default.  Perform the same operation in openvswitch for DNAT
    if no explicit SNAT is requested by the user and allocate a null binding
    for SNAT for packets in the "original" direction.

    Reported-at: https://bugzilla.redhat.com/1877128
    Suggested-by: Florian Westphal <fw at strlen.de>
    Fixes: 05752523e565 ("openvswitch: Interface with NAT.")
    Signed-off-by: Dumitru Ceara <dceara at redhat.com>
    Signed-off-by: Jakub Kicinski <kuba at kernel.org>

Fixes: f8f97cdce9ad ("datapath: Interface with NAT.")
Signed-off-by: Dumitru Ceara <dceara at redhat.com>
Acked-by: Paolo Valerio <pvalerio at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: bd056cb94d8ba22fe7bc10b27a0ea22b871add28
      https://github.com/openvswitch/ovs/commit/bd056cb94d8ba22fe7bc10b27a0ea22b871add28
  Author: Cian Ferriter <cian.ferriter at intel.com>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M lib/dpif-netdev-private-dfc.h
    M lib/dpif-netdev-private-thread.h

  Log Message:
  -----------
  dpif-netdev: Fix pmd thread comments to include SMC.

These comments are relevant to SMC too.

Fixes: 60d8ccae135f ("dpif-netdev: Add SMC cache after EMC cache")
Signed-off-by: Cian Ferriter <cian.ferriter at intel.com>
Acked-by: Kevin Traynor <ktraynor at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: b12242e0eaa2426176035e3aed2da6e54448f61b
      https://github.com/openvswitch/ovs/commit/b12242e0eaa2426176035e3aed2da6e54448f61b
  Author: lic121 <lic121 at chinatelecom.cn>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M AUTHORS.rst
    M lib/packets.h

  Log Message:
  -----------
  packets: Correct VXLAN_GPE_FLAGS_P macro name.

Fix macro name from "VLXAN_GPE_FLAGS_P" to "VXLAN_GPE_FLAGS_P".

Signed-off-by: lic121 <lic121 at chinatelecom.cn>
Reviewed-by: Greg Rose <gvrose8192 at gmail.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: b841e3cd4a282f917f55fa9c6fcefebefe06cde8
      https://github.com/openvswitch/ovs/commit/b841e3cd4a282f917f55fa9c6fcefebefe06cde8
  Author: Mark Gray <mark.d.gray at redhat.com>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M lib/dpif-netlink.c

  Log Message:
  -----------
  dpif-netlink: Fix feature negotiation for older kernels.

Older kernels do not reject unsupported features. This can lead
to a situation in which 'ovs-vswitchd' believes that a feature is
supported when, in fact, it is not.

This patch probes for this by attempting to set a known unsupported
feature.

Reported-by: Dumitru Ceara <dceara at redhat.com>
Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=2004083
Suggested-by: Ilya Maximets <i.maximets at ovn.org>
Signed-off-by: Mark Gray <mark.d.gray at redhat.com>
Tested-by: Dumitru Ceara <dceara at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 32899c8247e039c09e5c311ed56f7adcbce4665e
      https://github.com/openvswitch/ovs/commit/32899c8247e039c09e5c311ed56f7adcbce4665e
  Author: Sunil Pai G <sunil.pai.g at intel.com>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M acinclude.m4

  Log Message:
  -----------
  acinclude: Use standardized DPDK component defines.

The DPDK component defines have been renamed from RTE_LIBRTE_* to
macro's of the form:
  "RTE_" + <class> + "_" + drivername
as documented in the DPDK commit [1].  Use the new form of macros.

Macro's changed:
        OLD                   NEW
     ---------            ----------
RTE_LIBRTE_PMD_PCAP   --> RTE_NET_PCAP
RTE_LIBRTE_PMD_AF_XDP --> RTE_NET_AF_XDP
RTE_LIBRTE_MLX5_PMD   --> RTE_NET_MLX5
RTE_LIBRTE_MLX4_PMD   --> RTE_NET_MLX4

[1]: 762bfccc8abf ("config: remove compatibility build defines")

Signed-off-by: Sunil Pai G <sunil.pai.g at intel.com>
Reviewed-by: David Marchand <david.marchand at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: d41cac475c4cabcf2fa9785a5a4f53fc70967571
      https://github.com/openvswitch/ovs/commit/d41cac475c4cabcf2fa9785a5a4f53fc70967571
  Author: Cian Ferriter <cian.ferriter at intel.com>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M Documentation/howto/userspace-tunneling.rst

  Log Message:
  -----------
  docs/userspace-tunneling: Fix IP addresses for host2.

The IP addresses being recommended for the VM interface and the
"remote_ip" on the tunnel port are wrong. The host1 values were being
used before. Update to use the host2 values.

Signed-off-by: Cian Ferriter <cian.ferriter at intel.com>
Acked-by: Kevin Traynor <ktraynor at redhat.com>
Acked-by: Paolo Valerio <pvalerio at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 755cf31a39886bf629150f27028042b011a38da6
      https://github.com/openvswitch/ovs/commit/755cf31a39886bf629150f27028042b011a38da6
  Author: Kumar Amber <kumar.amber at intel.com>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M lib/dpdk-stub.c

  Log Message:
  -----------
  dpdk-stub: Change the ERR log to DBG.

When DPDK is not available and avx512 looks for isa
the function returns an error log which results in
unit test failures.

By logging a debug level log, this still shows up
in the vswitchd.log file, but won't fail unit tests
that do not have DPDK built in.

Suggested by: Ilya Maximets <i.maximets at ovn.org>
Signed-off-by: Kumar Amber <kumar.amber at intel.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: f9f3919828afd54bc6b61546b44a44d75f25ed5f
      https://github.com/openvswitch/ovs/commit/f9f3919828afd54bc6b61546b44a44d75f25ed5f
  Author: Remi Jouannet <remi.jouannet at outscale.com>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M utilities/ovs-ctl.in

  Log Message:
  -----------
  ovs-ctl: Add missing description for --ovs-vswitchd-options and --ovsdb-server-options to usage().

The options commit by fce20b8b73b1 were missing a description in
ovs-ctl help message.

Fixes: fce20b8b73b1 ("ovs-ctl: Permit to specify additional options")
Signed-off-by: Remi Jouannet <remi.jouannet at outscale.com>
Acked-by: Aaron Conole <aconole at redhat.com>
Reviewed-by: David Marchand <david.marchand at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 3486d81d17dadea72f0a580fdf00c92298d0f349
      https://github.com/openvswitch/ovs/commit/3486d81d17dadea72f0a580fdf00c92298d0f349
  Author: Ilya Maximets <i.maximets at ovn.org>
  Date:   2021-10-12 (Tue, 12 Oct 2021)

  Changed paths:
    M AUTHORS.rst

  Log Message:
  -----------
  AUTHORS: Add Remi Jouannet.

Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/803ed12e31b0...3486d81d17da


More information about the git mailing list