[ovs-git] [openvswitch/ovs] 031eff: netdev-dpdk: Fix RSS configuration for virtio.

wyjwang noreply at github.com
Thu Sep 16 00:49:57 UTC 2021


  Branch: refs/heads/branch-2.15
  Home:   https://github.com/openvswitch/ovs
  Commit: 031eff4563a6feeb58b7aa6aaa0043dbb7543fe7
      https://github.com/openvswitch/ovs/commit/031eff4563a6feeb58b7aa6aaa0043dbb7543fe7
  Author: David Marchand <david.marchand at redhat.com>
  Date:   2021-09-16 (Thu, 16 Sep 2021)

  Changed paths:
    M lib/netdev-dpdk.c

  Log Message:
  -----------
  netdev-dpdk: Fix RSS configuration for virtio.

In the future, virtio may support RSS.
In any case, it is safer to rely on exposed capabilities rather than
matching on driver names.

Signed-off-by: David Marchand <david.marchand at redhat.com>
Acked-by: Michael Santana <msantana at redhat.com>
Reviewed-by: Maxime Coquelin <maxime.coquelin at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 02b0c265c4d8a2c249217efab580bf4fbf5c37bd
      https://github.com/openvswitch/ovs/commit/02b0c265c4d8a2c249217efab580bf4fbf5c37bd
  Author: Yunjian Wang <wangyunjian at huawei.com>
  Date:   2021-09-16 (Thu, 16 Sep 2021)

  Changed paths:
    M lib/odp-util.c

  Log Message:
  -----------
  odp-util: Fix a null pointer dereference in odp_nsh_key_from_attr__().

This patch fixes (dereference after null check) coverity issue.
We should add null check of 'nsh_mask' to avoid passing NULL pointer
to memcpy() because the 'nsh_mask' maybe null.

Addresses-Coverity: ("Dereference after null check")
Fixes: 81fdabb94dd7 ("nsh: fix nested mask for OVS_KEY_ATTR_NSH")
Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
Acked-by: Aaron Conole <aconole at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 9f2f66c8ea651f89c076828f26c0d8b295c564b6
      https://github.com/openvswitch/ovs/commit/9f2f66c8ea651f89c076828f26c0d8b295c564b6
  Author: Yunjian Wang <wangyunjian at huawei.com>
  Date:   2021-09-16 (Thu, 16 Sep 2021)

  Changed paths:
    M lib/odp-util.c

  Log Message:
  -----------
  odp-util: Fix a null pointer dereference in odp_flow_format().

This patch fixes (dereference after null check) coverity issue.
For this reason, we should add null check of 'mask' before calling
nl_attr_find__() because the 'mask' maybe null.

Addresses-Coverity: ("Dereference after null check")
Fixes: e6cc0babc25d ("ovs-dpctl: Add mega flow support")
Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
Acked-by: Aaron Conole <aconole at redhat.com>
Acked-by: Vasu Dasari <vdasari at gmail.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: dd32deba6ebb917c4a70d4e34bd5efdfd1b9766c
      https://github.com/openvswitch/ovs/commit/dd32deba6ebb917c4a70d4e34bd5efdfd1b9766c
  Author: Yunjian Wang <wangyunjian at huawei.com>
  Date:   2021-09-16 (Thu, 16 Sep 2021)

  Changed paths:
    M lib/pcap-file.c

  Log Message:
  -----------
  pcap-file: Fix memory leak in ovs_pcap_open().

In ovs_pcap_open(), we allocate memory for the 'p_file'
structure but not released when fopen fails.

Addresses-Coverity: ("Resource leak")
Fixes: b6e840aed03e ("pcap-file: Add nanosecond resolution pcap support.")
Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
Acked-by: Aaron Conole <aconole at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


  Commit: 7788f1579877747b68559044443a2fbf25dad8ec
      https://github.com/openvswitch/ovs/commit/7788f1579877747b68559044443a2fbf25dad8ec
  Author: Yunjian Wang <wangyunjian at huawei.com>
  Date:   2021-09-16 (Thu, 16 Sep 2021)

  Changed paths:
    M lib/netdev-linux.c

  Log Message:
  -----------
  netdev-linux: Fix a null pointer dereference in netdev_linux_notify_sock().

If nl_sock_join_mcgroup() returns an error, the 'sock' is freed and
set to NULL. This issues will lead to null pointer deference in
nl_sock_listen_all_nsid(). To fix it, we call nl_sock_listen_all_nsid()
before joining the mcgroups.

Fixes: cf114a7fce80 ("netlink linux: enable listening to all nsids")
Signed-off-by: Yunjian Wang <wangyunjian at huawei.com>
Acked-by: Flavio Leitner <fbl at sysclose.org>
Reviewed-by: David Marchand <david.marchand at redhat.com>
Signed-off-by: Ilya Maximets <i.maximets at ovn.org>


Compare: https://github.com/openvswitch/ovs/compare/09cd9570d2c4...7788f1579877


More information about the git mailing list